GolfHos

Support => Help and Site Suggestions => Topic started by: Uisce Beatha on January 25, 2007, 12:36:23 PM



Title: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 12:36:23 PM
Reference:

http://www.golfhos.com/topic-1799

Scenario:

A thread is started by an overfed, long-haired leaping gnome.  He forgets to append to said title a spoiler alert.  Mortified, he rushes back in and fixes the problem by posting a new title.  He then retreats to his home and loved ones and prepares himself for the rituals of Seppuku.  The thing is, there have already been a few posts added to the thread and they all have the original title.  As people quote existing posts the recent posts page reflects the title as it appears in the quoted post.  'Tis a crapshoot.

Solution:

Normalize the damn database.  Errrrmmmm, I mean, is there a way to have the recent posts page reflect the title as held by the original post?


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 12:40:30 PM
Even after you edit the title, I think your original title remains until someone replies in the thread.  Scroll through the thread and look at the titles appearing the posts' headers -- you can see the changes.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 12:46:40 PM
Even after you edit the title, I think your original title remains until someone replies in the thread.  Scroll through the thread and look at the titles appearing the posts' headers -- you can see the changes.

Clive, what seems to happen is that the new post takes on its title one of two ways.

(1) If it's a simple 'reply' it gets the title of either the thread itself or the original post.  Hard to say if the former is even possible without seeing the schema.

(2) If it's a quoted response it gets the title of the quoted post. 

If you run down the thread you can kind of see how this plays out.  Keep in mind that my response to TFT was the first time I modified the title and then later I modified the title of the original post.   As everyone replied and quoted other posts the titles propagated accordingly.   


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 25, 2007, 12:52:34 PM
That's weird. i've got to run back to my UML class, but I'll look into this later.


Title: Re: Thread Titles and Unwanted Persistence
Post by: TFT on January 25, 2007, 12:55:43 PM
If anyone needs me I'll be on holodeck 4.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 02:18:43 PM
If anyone needs me I'll be on holodeck 4.

Speaking of Unwanted Persistence.   ::)


Title: Re: CLIVE IS A BIG PISSHEAD!
Post by: Clive on January 25, 2007, 02:33:30 PM
Clive, what seems to happen is that the new post takes on its title one of two ways.

(1) If it's a simple 'reply' it gets the title of either the thread itself or the original post.  Hard to say if the former is even possible without seeing the schema.

(2) If it's a quoted response it gets the title of the quoted post. 

If you run down the thread you can kind of see how this plays out.  Keep in mind that my response to TFT was the first time I modified the title and then later I modified the title of the original post.   As everyone replied and quoted other posts the titles propagated accordingly.
I think I see what you mean.  ::) ;D


Title: Re: CLIVE IS A *little* PISSHEAD!
Post by: Uisce Beatha on January 25, 2007, 02:37:03 PM
Clive, what seems to happen is that the new post takes on its title one of two ways.

(1) If it's a simple 'reply' it gets the title of either the thread itself or the original post.  Hard to say if the former is even possible without seeing the schema.

(2) If it's a quoted response it gets the title of the quoted post. 

If you run down the thread you can kind of see how this plays out.  Keep in mind that my response to TFT was the first time I modified the title and then later I modified the title of the original post.   As everyone replied and quoted other posts the titles propagated accordingly.
I think I see what you mean.  ::) ;D

LOL!!!  Don't tell Toys For Tots.  He'll go mad with power.


Title: Re: Uisce Beatha is French for Smelly Finger
Post by: TFT on January 25, 2007, 02:56:36 PM

LOL!!!  Don't tell Toys For Tots.  He'll go mad with power.

As if I'd stoop so low.


Title: TFT Sits Like A Little Bitch When He Pees
Post by: Clive on January 25, 2007, 02:59:35 PM

LOL!!!  Don't tell Toys For Tots.  He'll go mad with power.

As if I'd stoop so low.

Agreed.


Title: Re: It's only funny for so long, you know
Post by: TFT on January 25, 2007, 03:01:20 PM

LOL!!!  Don't tell Toys For Tots.  He'll go mad with power.

As if I'd stoop so low.

Agreed.

Gaylord.


Title: Re: Stroh is going to get really confused with all these title changes ;)
Post by: Torpedo on January 25, 2007, 04:20:35 PM
Weird thread. ;)


Title: LOL! Just happened.
Post by: stroh on January 25, 2007, 05:27:31 PM
Weird thread. ;)

I was looking all over for "that thread". ;D


Title: Test Change: Reply To OP
Post by: Clive on January 25, 2007, 05:37:44 PM
Test.


Title: Lawers have nothing better to do than change forum titles all day
Post by: Torpedo on January 25, 2007, 05:41:33 PM
Test.

Test.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 05:43:09 PM
Test.
In the board list, this thread shows up with the most recent title change.  But in Active Topics, it still shows the OP-associated title regardless of subsequent-post changes.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 05:44:04 PM
And my previous post was a reply to the post wherein I'd edited the title to "Test Change: Reply To OP".

Change didn't carry forward!


Title: Re: Lawers have nothing better to do than change forum titles all day
Post by: Uisce Beatha on January 25, 2007, 06:01:05 PM

Quoted Torp's "Lawers have nothing better to do than change forum titles all day" post.



Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 06:02:40 PM
Previous post reflected Torp's title on "Recent Posts" page.

Used "Reply" button at top of page on this one.  I expect the OP title to reflect.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 06:03:12 PM
Told ya.

I rule at IT.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 06:04:10 PM
You rule!


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 06:05:01 PM
As if I'd stoop so low.
Looks like you have to actually quote, not just click "Quote".


Title: Re: Thread Titles and Unwanted Persistence
Post by: Clive on January 25, 2007, 06:05:30 PM
Or not!

My quoted replies aren't perpetuating the changed title.  ???


Title: Re: Thread Titles and Unwanted Persistence
Post by: Torpedo on January 25, 2007, 06:08:26 PM
Or not!

My quoted replies aren't perpetuating the changed title.  ???

The internets just hate you. ;)


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 25, 2007, 06:11:46 PM
Or not!

My quoted replies aren't perpetuating the changed title.  ???

Only on the "Recent Posts" page.  At least that's how it works for me.  The "Active Topics" or whatever it's called always has the OP title.

You so unrule.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Torpedo on January 25, 2007, 06:12:57 PM
You so unrule.

lol :D


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 26, 2007, 10:33:45 AM

Solution:

Normalize the damn database.  Errrrmmmm, I mean, is there a way to have the recent posts page reflect the title as held by the original post?


I think I've fixed the Active Topics/Recent Posts by Category page so it now displays the original title.

However, the Recent Posts on the front page uses a very simple, fast query to get the last 30 posts, and I'm not sure I want to change it so that it uses the subject/title from the original post.  It might slow down the front page load time.

I'm very tempted to normalize the database, but that would be a serious branch from the smf codebase, and I'm hesitant to do that.  It would be much tougher to incorporate any patches or mods built by the SMF team and community.

One possible workaround might be when a user creates a new post to always overwrite the subject for that post with the current subject of the original post.  We don't really gain much from allowing a responder to modify the subject, anyway.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 26, 2007, 10:35:56 AM
One possible workaround might be when a user creates a new post to always overwrite the subject for that post with the current subject of the original post.  We don't really gain much from allowing a responder to modify the subject, anyway.

It seems it might be easy to disable or hide the subject field from any other than the OP and admins.


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 26, 2007, 12:54:38 PM
One possible workaround might be when a user creates a new post to always overwrite the subject for that post with the current subject of the original post.  We don't really gain much from allowing a responder to modify the subject, anyway.

It seems it might be easy to disable or hide the subject field from any other than the OP and admins.

Yeah, I actually changed the subject field to readonly for the non-OP last night, but then changed it back.  It solved the problem of pranksters changing the subject for fun, but doesn't solve the original problem of a person replying to a post that had the original title (w/o spoiler).


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 26, 2007, 01:36:22 PM
I understand the (de)normalization issue and it's fair enough you don't want to delve into that.  It seems like your workaround idea might be the way to go.


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 26, 2007, 01:58:27 PM
Hmm, I thought about this some more and making the Subject readonly does get us get us halfway there, so I put that change back.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 26, 2007, 04:06:47 PM
Hmm, I thought about this some more and making the Subject readonly does get us get us halfway there, so I put that change back.

New Topic from within a forum isn't letting me enter a subject. 

 :(


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 26, 2007, 04:08:44 PM
LOL!  I just realized it too when I tried to create a new thread.

I just backed out the change.  Sorry about that. :-[


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 26, 2007, 04:09:59 PM
LOL!  I just realized it too when I tried to create a new thread.

I just backed out the change.  Sorry about that. :-[

No worries.  I just modified an earlier one-post thread of mine that everyone ignored.   ;)


Title: Re: Thread Titles and Unwanted Persistence
Post by: Uisce Beatha on January 26, 2007, 04:12:01 PM
LOL!  I just realized it too when I tried to create a new thread.

I just backed out the change.  Sorry about that. :-[

No worries.  I just modified an earlier one-post thread of mine that everyone ignored.   ;)

Eeek.  But modifications don't register on recent posts so it's on page 87.   >:(

http://www.golfhos.com/forum/index.php/topic,1497.msg18448.html


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 29, 2007, 12:13:42 PM
LOL!  I just realized it too when I tried to create a new thread.

I just backed out the change.  Sorry about that. :-[

I think I've got the workaround working properly now.  When replying, the Subject field is now readonly, but not when creating a new thread.  Also, when replying, the subject field should be pre-filled with the subject of the original post, and not the subject of the post that you're replying to.


Title: Re: Thread Titles and Unwanted Persistence
Post by: Torpedo on January 29, 2007, 07:18:43 PM
I think I've got the workaround working properly now.  When replying, the Subject field is now readonly, but not when creating a new thread.  Also, when replying, the subject field should be pre-filled with the subject of the original post, and not the subject of the post that you're replying to.

Well if the subject is read-only then wouldn't the subject of the post your replying to have to be the same as the original?


Title: Re: Thread Titles and Unwanted Persistence
Post by: dystopia on January 29, 2007, 10:27:02 PM
I think I've got the workaround working properly now.  When replying, the Subject field is now readonly, but not when creating a new thread.  Also, when replying, the subject field should be pre-filled with the subject of the original post, and not the subject of the post that you're replying to.

Well if the subject is read-only then wouldn't the subject of the post your replying to have to be the same as the original?

Not always, that's why this is more complicated than it appears at first. 

Example:

- Aske creates a thread called "Masters OMG!!!!  I <3 Tiger!"
- stroh replies to the original post and propagates the original title.
- Aske goes back and edits the original title to now say "Masters (Spoiler)"
- Now if spaceage goes and quotes stroh's post, previously, spaceage's reply would now have a readonly subject of "Masters OMG!!!!", but after this change spaceage's reply has a readonly subject of the original post, which has been changed ("Masters (Spoiler)").

Does that make sense?


Title: Re: Thread Titles and Unwanted Persistence
Post by: Torpedo on January 29, 2007, 10:29:24 PM
I think I've got the workaround working properly now.  When replying, the Subject field is now readonly, but not when creating a new thread.  Also, when replying, the subject field should be pre-filled with the subject of the original post, and not the subject of the post that you're replying to.

Well if the subject is read-only then wouldn't the subject of the post your replying to have to be the same as the original?

Not always, that's why this is more complicated than it appears at first. 

Example:

- Aske creates a thread called "Masters OMG!!!!  I <3 Tiger!"
- stroh replies to the original post and propagates the original title.
- Aske goes back and edits the original title to now say "Masters (Spoiler)"
- Now if spaceage goes and quotes stroh's post, previously, spaceage's reply would now have a readonly subject of "Masters OMG!!!!", but after this change spaceage's reply has a readonly subject of the original post, which has been changed ("Masters (Spoiler)").

Does that make sense?

Yeah, I had forgot about edits. :)